ensure password is masked on ecr login (#538)

stargate · Sep 24, 2023 · df2e73e · df2e73e
1 parent 7aabed6
commit df2e73e
Show file tree

Hide file tree

Showing 5 changed files with 14 additions and 0 deletions.
diff --git a/.github/workflows/continuous-integration.yaml b/.github/workflows/continuous-integration.yaml
@@ -102,6 +102,8 @@ jobs:
       - name: Login to Amazon ECR
         id: login-ecr
         uses: aws-actions/amazon-ecr-login@v1
+        with:
+          mask-password: 'true'
 
       # run the int tests
       - name: Integration Test

diff --git a/.github/workflows/docker-image-publish.yaml b/.github/workflows/docker-image-publish.yaml
@@ -61,6 +61,8 @@ jobs:
       - name: Login to Amazon ECR
         id: login-ecr
         uses: aws-actions/amazon-ecr-login@v1
+        with:
+          mask-password: 'true'
 
       - name: Build and push (Amazon ECR)
         run: |
@@ -97,6 +99,8 @@ jobs:
       - name: Login to Amazon ECR
         id: login-ecr
         uses: aws-actions/amazon-ecr-login@v1
+        with:
+          mask-password: 'true'
 
       - name: Sign a docker image
         shell: bash

diff --git a/.github/workflows/performance-testing.yaml b/.github/workflows/performance-testing.yaml
@@ -85,6 +85,8 @@ jobs:
       - name: Login to Amazon ECR
         id: login-ecr
         uses: aws-actions/amazon-ecr-login@v1
+        with:
+          mask-password: 'true'
 
       # Use docker-compose to start required stack
       # Pull JSON API image from ECR corresponding to latest commit on main branch

diff --git a/.github/workflows/postman-docker.yaml b/.github/workflows/postman-docker.yaml
@@ -42,6 +42,8 @@ jobs:
       - name: Login to Amazon ECR
         id: login-ecr
         uses: aws-actions/amazon-ecr-login@v1
+        with:
+          mask-password: 'true'
 
         # Run Stargate coordinator in developer mode to save time / resources
         # Pull JSON API image from ECR corresponding to latest commit on main branch

diff --git a/.github/workflows/release.yaml b/.github/workflows/release.yaml
@@ -130,6 +130,8 @@ jobs:
       - name: Login to Amazon ECR
         id: login-ecr
         uses: aws-actions/amazon-ecr-login@v1
+        with:
+          mask-password: 'true'
 
       # downloads and prepares datastax assets
       - name: Download branding assets
@@ -186,6 +188,8 @@ jobs:
       - name: Login to Amazon ECR
         id: login-ecr
         uses: aws-actions/amazon-ecr-login@v1
+        with:
+          mask-password: 'true'
 
       - name: Sign a docker image
         shell: bash