Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify ErrorCodes COMMAND_NOT_IMPLEMENTED and NO_COMMAND_MATCHED into COMMAND_UNKNOWN #1232

Closed
tatu-at-datastax opened this issue Jul 3, 2024 · 0 comments · Fixed by #1233
Assignees

Comments

@tatu-at-datastax
Copy link
Contributor

tatu-at-datastax commented Jul 3, 2024

(alternative: unify as existing COMMAND_NOT_IMPLEMENTED -- I like COMMAND_ as prefix)
(another alternative: COMMAND_UNRECOGNIZED)

Currently there are 2 separate ErrorCodes used essentially for the same issue: case of API request referring to Command that we do not recognized (unknown, unmapped, mis-spelled).
Neither name is quite right:

  • COMMAND_NOT_IMPLEMENTED -- this leads to assumption that such command might be added in future, which may or (more likely) may not be the case
  • NO_COMMAND_MATCHED -- slightly better, but should start with COMMAND. Also, not sure "matching" conveys exact meaning.

Neither response is widely used: for past 48 hours there are not a single instance of either (out of ~5,000 error responses) so renaming should be safe to do at this point.

EDIT: Actually COMMAND_NOT_IMPLEMENTED is an internal failure for known command without matching resolver. Needs to be changed to new SERVER_INTERNAL_ERROR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant