Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Confirm all response messages against spec #178

Closed
amorton opened this issue Feb 23, 2023 · 4 comments
Closed

Confirm all response messages against spec #178

amorton opened this issue Feb 23, 2023 · 4 comments
Assignees

Comments

@amorton
Copy link
Contributor

amorton commented Feb 23, 2023

Issue #175 has updates to the API spec that locks in the response messages from a meeting today.

The API spec now has a general description of the request and response, and each command specifies the data is should return.

This is a catchall ticket to ensure those changes to the spec and the code are in sync. There may be some changes that have already happened like removing the updatedId's list from the status.

I think the spec changes are good based on the meeting today, and we can probably start implementing.

@maheshrajamani and @ivansenic this also includes the response data when there are errors. Still have changes for #160 in my git stash, but this describes what the response should be.

@sync-by-unito
Copy link

sync-by-unito bot commented Feb 28, 2023

➤ Ivan Senic commented:

PR #1 countDocuments command: #202 ( https://github.com/stargate/jsonapi/pull/202|smart-link )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants