Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate if Jackson 2.15 provided "fast floating-point" improves BigDecimal reads, enable #653

Closed
tatu-at-datastax opened this issue Nov 16, 2023 · 1 comment · Fixed by #756
Assignees

Comments

@tatu-at-datastax
Copy link
Contributor

(similar to #652 but for reading)

As per: https://medium.com/@cowtowncoder/jackson-2-15-yet-faster-floating-point-reads-fd6d5a0b769a Jackson 2.15 and later have opt-in "fast FP reads" feature, which has measurable performance benefit for reading float/double (and wrapper) values. If it also helps with BigDecimal (to be investigated), we should enable this given that the incoming JSON document often has huge vectors (read: tons of FP values) to decode.

Existing test(s) in: https://github.com/FasterXML/jackson-benchmarks should be possible to modify to test out low-level performance difference, if any; and if proven to help with BigDecimal should enable setting.

@tatu-at-datastax
Copy link
Contributor Author

As per https://medium.com/@cowtowncoder/jackson-2-16-faster-bigdecimal-reads-b65eb127b899 there is measurable improvement in performance, but I am still hoping to test a more "FP-heavy" case to quantify benefit for Vector use case.

For somewhat lighter case discussed in above blog post, performance improvement for JSON doc with big Object with keys, short FP numbers, was +10%. Still worth it so will proceed one way another soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant