Add support for "star" inclusion/exclusion (include all/exclude all) #1008
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tatu-at-datastax
changed the title
kathirsvn
reviewed
Apr 1, 2024
| { | ||
| "find": { | ||
| "sort" : {"$vector" : [0.15, 0.1, 0.1, 0.35, 0.55]}, | ||
| "projection" : {"*" : 1}, |
There was a problem hiding this comment.
Can we add a test case with non-zero and non-one value as well? (to make sure it behaves as true)?
There was a problem hiding this comment.
@kathirsvn Sounds good, will add in suitable place.
There was a problem hiding this comment.
Added more unit tests to cover non-0/non-1 numbers, booleans.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Adds support for 2 special query projections:
as per #1001, as convenience shortcuts that ignore special field (_id, $vector, $vectorize) logic regarding default inclusion/exclusion.
Also prepares for bigger fix, #1005.
Which issue(s) this PR fixes:
Fixes #1001
Checklist