Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move embedding-service class under embedding package #1054

Merged
merged 3 commits into from
May 3, 2024
Merged

Move embedding-service class under embedding package #1054

merged 3 commits into from
May 3, 2024

Conversation

tatu-at-datastax
Copy link
Contributor

What this PR does:

Moves embedding-gateway - related class to proper Java package

Which issue(s) this PR fixes:
N/A

Checklist

  • Changes manually tested
  • Automated Tests added/updated
  • Documentation added/updated
  • CLA Signed: DataStax CLA

@tatu-at-datastax tatu-at-datastax self-assigned this May 2, 2024
@tatu-at-datastax tatu-at-datastax requested a review from a team as a code owner May 2, 2024 19:34
@tatu-at-datastax
Copy link
Contributor Author

@maheshrajamani I realized that this may or may not make sense. Basically:

  1. If this is for use by Data API itself, current location makes sense
  2. If this is for use by Embedding gateway (separate package), should be moved as with this PR.

Just LMK either way so I can either close PR (if (1)), otherwise merge pending approval (if (2)).

@maheshrajamani
Copy link
Contributor

maheshrajamani commented May 3, 2024 •
edited
Loading

  • If this is for use by Data API itself, current location makes sense

This header is resolved in data api, but can be moved because the resolved value is for calling embedding provider service.

@tatu-at-datastax tatu-at-datastax merged commit 66d8423 into main May 3, 2024
3 checks passed
@tatu-at-datastax tatu-at-datastax deleted the tatu/refactor-embedding-classes branch May 3, 2024 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maheshrajamani maheshrajamani maheshrajamani approved these changes

Assignees

@tatu-at-datastax tatu-at-datastax

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tatu-at-datastax @maheshrajamani