Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update createCollection Command #1059

Merged
merged 8 commits into from
May 6, 2024
Merged

Conversation

Hazel-Datastax
Copy link
Contributor

What this PR does:

  1. change VectorizeServiceAuthentication object to Map
  2. remove secretName

Which issue(s) this PR fixes:
Fixes #

Checklist

  • Changes manually tested
  • Automated Tests added/updated
  • Documentation added/updated
  • CLA Signed: DataStax CLA

@Hazel-Datastax Hazel-Datastax requested a review from a team as a code owner May 6, 2024 16:29
# Conflicts:
#	src/main/java/io/stargate/sgv2/jsonapi/service/resolver/model/impl/CreateCollectionCommandResolver.java
@Hazel-Datastax Hazel-Datastax changed the title [WIP] Update createCollection Command Update createCollection Command May 6, 2024
@Hazel-Datastax Hazel-Datastax merged commit d37a835 into main May 6, 2024
3 checks passed
@Hazel-Datastax Hazel-Datastax deleted the hazel/create_collection branch May 6, 2024 21:50
Copy link
Collaborator

@vkarpov15 vkarpov15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants