Made the grpc to use Managed channel directly to use it in blocking mode #1084
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yuqi-Du
approved these changes
May 13, 2024
| @ConfigProperty(name = "quarkus.grpc.clients.embedding.port") | ||
| private int port; | ||
|
|
||
| private ManagedChannel channel = null; |
There was a problem hiding this comment.
Should this be volatile if there's no other synchronization?
|
|
||
| @Inject DataApiRequestInfo dataApiRequestInfo; | ||
|
|
||
| public boolean validate(String provider, String value) { | ||
| if (channel == null) { |
There was a problem hiding this comment.
how about synchronization? Could make channel synchronized; if this is used concurrently is it not necessary to consider synchronization?
| @@ -31,4 +44,8 @@ public boolean validate(String provider, String value) { | |||
| } | |||
| return validateCredentialResponse.getValidity(); | |||
| } | |||
|
|
|||
| void onStop(@Observes ShutdownEvent ev) { | |||
| channel.shutdown(); | |||
There was a problem hiding this comment.
Can channel ever remain null?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Injecting blocking stub doesn't work on eventloop thread. Made token validation call as blocking channel.
Checklist