Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Offline Mode - Index cql & Vector fixes #1115

Merged
merged 4 commits into from
May 29, 2024
Merged

Conversation

kathirsvn
Copy link
Contributor

What this PR does:

  • Changes to include the index statements in the response returned by beginSession of OfflineCommandProcessor.java
  • Fix to allow writing rows without $vector into the SSTable when the table definition has vector search enabled.

Which issue(s) this PR fixes:
Fixes #

Checklist

  • Changes manually tested
  • Automated Tests added/updated
  • Documentation added/updated
  • CLA Signed: DataStax CLA

@kathirsvn kathirsvn requested a review from a team as a code owner May 23, 2024 19:24
Copy link
Contributor

@maheshrajamani maheshrajamani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kathirsvn kathirsvn merged commit 84dc525 into main May 29, 2024
3 checks passed
@kathirsvn kathirsvn deleted the offline_index_cql_fixes branch May 29, 2024 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants