Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rollback cql-session check #1138

Merged
merged 1 commit into from
Jun 3, 2024
Merged

rollback cql-session check #1138

merged 1 commit into from
Jun 3, 2024

Conversation

Yuqi-Du
Copy link
Contributor

@Yuqi-Du Yuqi-Du commented Jun 3, 2024

Checklist

  • Changes manually tested
  • Automated Tests added/updated
  • Documentation added/updated
  • CLA Signed: DataStax CLA

@Yuqi-Du Yuqi-Du requested a review from a team as a code owner June 3, 2024 19:09
@Yuqi-Du Yuqi-Du merged commit e42550a into main Jun 3, 2024
4 checks passed
@Yuqi-Du Yuqi-Du deleted the rollback-session-check branch June 3, 2024 20:18
@jeffreyscarpenter
Copy link
Contributor

Apologies for getting to this late, but I was wondering if we should keep the session check capability in the code as something disabled by default but that can be enabled by setting a property? Then perhaps it would be easier to re-enable later. @Yuqi-Du @kathirsvn

@kathirsvn
Copy link
Contributor

Sure. In that case, we can simply comment out the call made to isAstraSessionValid method in CQLSessionCache.java.
@Yuqi-Du We can leave the unit tests also since they test the method directly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants