Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bridge-Removal: Tests file cleanup with necessary profile and resources #1141

Merged
merged 3 commits into from
Jun 4, 2024
Merged

Bridge-Removal: Tests file cleanup with necessary profile and resources #1141

merged 3 commits into from
Jun 4, 2024

Conversation

Yuqi-Du
Copy link
Contributor

@Yuqi-Du Yuqi-Du commented Jun 4, 2024 •
edited
Loading

Background: There are too many test files change, trying to separate there changes as this separate PR.

  • Remove the quarkus-common test scope dependency, provided with necessary profile and resources.
  • Add NoGlobalTestResourceProfile and IntegrationUtils
  • remove CustomValueSerializers, as it is not used anywhere. Remove CustomValueSerializersTest at the same time.

Checklist

  • Changes manually tested
  • Automated Tests added/updated
  • Documentation added/updated
  • CLA Signed: DataStax CLA

@Yuqi-Du Yuqi-Du requested a review from a team as a code owner June 4, 2024 00:08
@tatu-at-datastax
Copy link
Contributor

Good idea! Will review.

@Yuqi-Du Yuqi-Du merged commit 2c517b8 into main Jun 4, 2024
4 checks passed
@Yuqi-Du Yuqi-Du deleted the bridge-removal-tests branch June 4, 2024 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tatu-at-datastax tatu-at-datastax tatu-at-datastax approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Yuqi-Du @tatu-at-datastax