Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support includeSortVector option for find and findOne command #1151

Merged
merged 18 commits into from
Jun 11, 2024
Merged

Support includeSortVector option for find and findOne command #1151

merged 18 commits into from
Jun 11, 2024

Conversation

maheshrajamani
Copy link
Contributor

@maheshrajamani maheshrajamani commented Jun 6, 2024 •
edited
Loading

What this PR does:
Support includeSortVector option to return the vector used for ANN search for find and findOne command.

Checklist

  • Changes manually tested
  • Automated Tests added/updated
  • Documentation added/updated
  • CLA Signed: DataStax CLA

@maheshrajamani maheshrajamani self-assigned this Jun 6, 2024
@maheshrajamani maheshrajamani requested a review from a team as a code owner June 6, 2024 15:08
@maheshrajamani maheshrajamani changed the title [WIP] Support includeSortVector option Support includeSortVector option for find and findOne command Jun 6, 2024
vkarpov15
vkarpov15 reviewed Jun 8, 2024
View reviewed changes
Copy link
Collaborator

@vkarpov15 vkarpov15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of small comments but LGTM overall

src/main/java/io/stargate/sgv2/jsonapi/service/operation/model/impl/FindOperation.java Outdated Show resolved Hide resolved
src/test/java/io/stargate/sgv2/jsonapi/api/v1/VectorSearchIntegrationTest.java Outdated Show resolved Hide resolved
tatu-at-datastax
tatu-at-datastax approved these changes Jun 10, 2024
View reviewed changes
Copy link
Contributor

@tatu-at-datastax tatu-at-datastax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@maheshrajamani maheshrajamani merged commit 273a7fe into main Jun 11, 2024
5 of 6 checks passed
@maheshrajamani maheshrajamani deleted the include-sort-vector branch June 11, 2024 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tatu-at-datastax tatu-at-datastax tatu-at-datastax approved these changes

@vkarpov15 vkarpov15 vkarpov15 left review comments

Assignees

@maheshrajamani maheshrajamani

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@maheshrajamani @vkarpov15 @tatu-at-datastax