Add 'returnDocumentResponses' for "insertMany" #1161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vkarpov15
reviewed
Jun 12, 2024
src/main/java/io/stargate/sgv2/jsonapi/api/model/command/CommandStatus.java
Outdated
Show resolved
Hide resolved
tatu-at-datastax
changed the title
tatu-at-datastax
changed the title
…urnDocumentResponses)
| @@ -46,7 +46,7 @@ public record CommandResult( | |||
| nullable = true) | |||
| }) | |||
| Map<CommandStatus, Object> status, | |||
| @Schema(nullable = true) List<Error> errors) { | |||
| @JsonInclude(JsonInclude.Include.NON_EMPTY) @Schema(nullable = true) List<Error> errors) { | |||
There was a problem hiding this comment.
Adding this so that both null and [ ] values are skipped (not just nulls)
| } | ||
|
|
||
| private static CommandResult.Error getError(DocumentId documentId, Throwable throwable) { | ||
| String message = | ||
| "Failed to insert document with _id %s: %s".formatted(documentId, throwable.getMessage()); | ||
|
|
There was a problem hiding this comment.
This code was not being used, not sure why it was there (ThrowableToErrorMapper handles this logic)
| @@ -18,12 +16,10 @@ | |||
| public class InsertManyCommandResolver implements CommandResolver<InsertManyCommand> { | |||
|
|
|||
| private final Shredder shredder; | |||
| private final ObjectMapper objectMapper; | |||
There was a problem hiding this comment.
Was not being used, removed.
Yuqi-Du
approved these changes
Jun 18, 2024
src/main/java/io/stargate/sgv2/jsonapi/service/operation/model/impl/InsertOperation.java
Show resolved
Hide resolved
src/main/java/io/stargate/sgv2/jsonapi/service/operation/model/impl/InsertOperationPage.java
Outdated
Show resolved
Hide resolved
src/main/java/io/stargate/sgv2/jsonapi/service/operation/model/impl/InsertOperationPage.java
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Adds support for requesting returning of doc ids of successful and failed inserts with "insertMany" command
Which issue(s) this PR fixes:
N/A
Checklist