Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Align Open AI text-embedding-3 dimension defaults to LangChain expectations #1162

Merged
merged 2 commits into from
Jun 12, 2024
Merged

Align Open AI text-embedding-3 dimension defaults to LangChain expectations #1162

merged 2 commits into from
Jun 12, 2024

Conversation

Hazel-Datastax
Copy link
Contributor

What this PR does:
Align Open AI text-embedding-3 dimension defaults to LangChain expectations

Which issue(s) this PR fixes:
Fixes Jira C2-3563

Checklist

  • Changes manually tested
  • Automated Tests added/updated
  • Documentation added/updated
  • CLA Signed: DataStax CLA

@Hazel-Datastax Hazel-Datastax requested a review from a team as a code owner June 12, 2024 01:05
amorton
amorton approved these changes Jun 12, 2024
View reviewed changes
Copy link
Contributor

@amorton amorton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@Hazel-Datastax Hazel-Datastax merged commit 1dadaa0 into main Jun 12, 2024
4 checks passed
@Hazel-Datastax Hazel-Datastax deleted the hazel/update_default branch June 12, 2024 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amorton amorton amorton approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Hazel-Datastax @amorton