Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

closes #56: remove WebApplicationException from the error responses #119

Merged
merged 1 commit into from
Feb 16, 2023
Merged

closes #56: remove WebApplicationException from the error responses #119

merged 1 commit into from
Feb 16, 2023

Conversation

ivansenic
Copy link
Contributor

I tried to simulate any further deserialization exceptions, but was not able to (see #56 (comment)). Thus I simply removed WebApplicationException from the responses as requested by @maheshrajamani.

@ivansenic ivansenic requested a review from a team as a code owner February 15, 2023 15:17
maheshrajamani
maheshrajamani approved these changes Feb 15, 2023
View reviewed changes
Copy link
Contributor

@maheshrajamani maheshrajamani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ivansenic ivansenic merged commit ff24e79 into main Feb 16, 2023
@ivansenic ivansenic deleted the ise-56-json-deser branch February 16, 2023 09:08
@ivansenic ivansenic mentioned this pull request Feb 16, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maheshrajamani maheshrajamani maheshrajamani approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ivansenic @maheshrajamani