Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hint and displayName in parameters #1267

Merged
merged 6 commits into from
Jul 15, 2024
Merged

Conversation

Hazel-Datastax
Copy link
Contributor

What this PR does:
Add hint and displayName in parameters

Which issue(s) this PR fixes:
Fixes Jira C2-3587

Checklist

  • Changes manually tested
  • Automated Tests added/updated
  • Documentation added/updated
  • CLA Signed: DataStax CLA

@Hazel-Datastax Hazel-Datastax requested a review from a team as a code owner July 12, 2024 16:06
@Hazel-Datastax
Copy link
Contributor Author

Corresponding changes in EGW: https://github.com/riptano/embedding-gateway/pull/69

@Hazel-Datastax
Copy link
Contributor Author

Corresponding changes in the deployment: https://github.com/riptano/serverless-platform-charts/pull/1105

@Hazel-Datastax Hazel-Datastax merged commit 6007782 into main Jul 15, 2024
4 checks passed
@Hazel-Datastax Hazel-Datastax deleted the hazel/update_config branch July 15, 2024 15:19
Copy link
Collaborator

@vkarpov15 vkarpov15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants