Added ValidatableCommandClause POC #1309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Encapsulates behavior for clauses that can be validated and better supports schema object types.
2 tasks
| */ | ||
| static <T extends SchemaObject> void maybeValidate( | ||
| CommandContext<T> commandContext, ValidatableCommandClause validatable) { | ||
| if (validatable == null) { |
There was a problem hiding this comment.
Is null legal? Assumption being that missing Clause is always valid thing?
tatu-at-datastax
approved these changes
Jul 25, 2024
|
Reviewed, approach is clear. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Encapsulates behaviour for clauses that can be validated and better supports schema object types.
This is a POC for adding this, just to the level needed to make table code work.
I will create a ticket to centralize all of the validation, based on this approach, and add here.
See #1310
NOTE : THIS PR DOES NOT CLOSE THE ISSUE ABOVE ^^^^
Which issue(s) this PR fixes:
Fixes #
Checklist