Fix #1383: map most recognized SERVER_ errors to 504 or 502, leave 500 for unrecognized #1384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…0 for unrecognized
...java/io/stargate/sgv2/jsonapi/service/operation/collections/FindCollectionOperationTest.java
Show resolved
Hide resolved
Comment on lines
92
to
93
| .toApiException("(DriverException/ClosedConnectionException) %s", message) | ||
| .getCommandResultError(Response.Status.GATEWAY_TIMEOUT); |
There was a problem hiding this comment.
Why here is GATEWAY_TIMEOUT not BAD_GATEWAY?
There was a problem hiding this comment.
Let me double-check; you are right seems odd.
There was a problem hiding this comment.
@Hazel-Datastax yes, you are right: should be BAD_GATEWAY -- changing. Thank you!
Hazel-Datastax
approved these changes
Sep 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Maps most former 500 http failures to 504 or 502, to indicate these are recognized failures with backend DB; 500 remains for unknown/unrecognized exceptions
Which issue(s) this PR fixes:
Fixes #1383
Checklist