Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove AWS bedrock IT test #1402

Merged
merged 2 commits into from
Sep 11, 2024
Merged

Remove AWS bedrock IT test #1402

merged 2 commits into from
Sep 11, 2024

Conversation

Yuqi-Du
Copy link
Contributor

@Yuqi-Du Yuqi-Du commented Sep 10, 2024

Notice this integration test is running (but skipped) for unit test. This is causing some noise.

[INFO]  T E S T S
[INFO] -------------------------------------------------------
[INFO] Running io.stargate.sgv2.jsonapi.api.v1.AwsBedrockVectorSearchIntegrationTest
Warning:  Tests run: 1, Failures: 0, Errors: 0, Skipped: 1, Time elapsed: 0.004 s -- in io.stargate.sgv2.jsonapi.api.v1.AwsBedrockVectorSearchIntegrationTest

Since we don't have provider keys configured in data api repo, these tests will not be executed.
And this is duplicate from what we have in EGW.

Checklist

  • Changes manually tested
  • Automated Tests added/updated
  • Documentation added/updated
  • CLA Signed: DataStax CLA

@Yuqi-Du Yuqi-Du marked this pull request as ready for review September 10, 2024 16:25
@Yuqi-Du Yuqi-Du requested a review from a team as a code owner September 10, 2024 16:25
@tatu-at-datastax
Copy link
Contributor

Approved.

@Yuqi-Du Yuqi-Du merged commit 4655a39 into main Sep 11, 2024
3 checks passed
@Yuqi-Du Yuqi-Du deleted the delete-aws-bedrock-IT branch September 11, 2024 00:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tatu-at-datastax tatu-at-datastax tatu-at-datastax approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Yuqi-Du @tatu-at-datastax