Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove no longer used WritableDocRow Fixes #1410 #1413

Merged
merged 1 commit into from
Sep 12, 2024
Merged

Remove no longer used WritableDocRow Fixes #1410 #1413

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions src/main/java/io/stargate/sgv2/jsonapi/service/shredding/WritableDocRow.java
View file
Open in desktop

This file was deleted.

10 changes: 1 addition & 9 deletions ...java/io/stargate/sgv2/jsonapi/service/shredding/collections/WritableShreddedDocument.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,6 @@
import com.fasterxml.jackson.databind.node.ArrayNode;
import com.fasterxml.jackson.databind.node.ObjectNode;
import io.stargate.sgv2.jsonapi.exception.ErrorCodeV1;
import io.stargate.sgv2.jsonapi.service.shredding.DocRowIdentifer;
import io.stargate.sgv2.jsonapi.service.shredding.WritableDocRow;
import io.stargate.sgv2.jsonapi.util.JsonUtil;
import java.math.BigDecimal;
import java.util.Arrays;
Expand Down Expand Up @@ -43,8 +41,7 @@ public record WritableShreddedDocument(
Map<JsonPath, Date> queryTimestampValues,
Set<JsonPath> queryNullValues,
float[] queryVectorValues,
UUID nextTxID)
implements WritableDocRow {
UUID nextTxID) {

@Override
public boolean equals(Object o) {
Expand Down Expand Up @@ -87,11 +84,6 @@ public int hashCode() {
return result;
}

@Override
public DocRowIdentifer docRowID() {
return id();
}

public static Builder builder(DocumentId id, UUID txID, String docJson, JsonNode docJsonNode) {
return new Builder(id, txID, docJson, docJsonNode);
}
Expand Down
7 changes: 1 addition & 6 deletions src/main/java/io/stargate/sgv2/jsonapi/service/shredding/tables/WriteableTableRow.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
* <li>All types have been converted to what he driver expects.
* </ul>
*/
public class WriteableTableRow implements WritableDocRow, PrettyPrintable {
public class WriteableTableRow implements PrettyPrintable {

private final TableSchemaObject tableSchemaObject;
private final OrderedCqlNamedValueContainer keyColumns;
Expand Down Expand Up @@ -76,11 +76,6 @@ public CqlNamedValueContainer allColumns() {
return allColumns;
}

@Override
public DocRowIdentifer docRowID() {
return id;
}

public RowId rowId() {
return id;
}
Expand Down