-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
simplify the NamedValueContainers structure #1414
Conversation
Fixes #1411 all containers are now ordered, removed interfaces no longer needed
.append("{columnName=") | ||
.append(name().getName()) | ||
.append(", value=") | ||
.append(value()) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
idea: include type (getClass()
) of value in parenthesis? (often good to know if it's String "1" or Long
1
f.ex)
} | ||
|
||
public JsonNamedValueContainer(Collection<JsonNamedValue> values) { | ||
super(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I assume super(values)
would not work?
} | ||
|
||
public NamedValueContainer(Collection<NvT> values) { | ||
super(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(same as earlier -- assuming super(values);
wouldn't work due to... type mismatch or something?)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Fixes #1411
all containers are now ordered, removed interfaces no longer needed
What this PR does:
Which issue(s) this PR fixes:
Fixes #
Checklist