Fixes #1429: add ITs to verify handling of "fractional ints" (allowed/non-allowed) #1432
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng from FindOne - test
| @@ -205,52 +193,6 @@ public void findOneDocIdKey() { | |||
|
|
|||
| @Nested | |||
| @Order(3) | |||
| @TestClassOrder(ClassOrderer.OrderAnnotation.class) | |||
There was a problem hiding this comment.
Move this test to new, refactored InsertOneTableIntegrationTests (see below).
|
|
||
| @Nested | ||
| @Order(1) | ||
| class InsertTextColumns { |
There was a problem hiding this comment.
Moved from test above since it really exercises InsertOne, not FindOne.
|
|
||
| @Nested | ||
| @Order(2) | ||
| class InsertIntColumns { |
There was a problem hiding this comment.
And these are the new tests for #1429 .
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Adds more testing for conversion to CQL int types; specifically Integration Tests to verify end-to-end handling (basic unit tests exists but cannot fully verify scientific notation f.ex).
Which issue(s) this PR fixes:
Fixes #1429
Checklist