Fix #1417: optimize/improve codec lookup handling #1443
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tatu-at-datastax
changed the title
amorton
reviewed
Sep 24, 2024
| } | ||
| } | ||
|
|
||
| public static JSONCodecRegistry create(List<JSONCodec<?, ?>> codecs) { |
There was a problem hiding this comment.
this static factory seems unnecessary, it has one line that calls the constructor
| this.codecs = Objects.requireNonNull(codecs, "codecs must not be null"); | ||
| private JSONCodecRegistry(List<JSONCodec<?, ?>> codecs) { | ||
| Objects.requireNonNull(codecs, "codecs must not be null"); | ||
| this.codecsByCQLType = new HashMap<>(); |
There was a problem hiding this comment.
nit: unnecessary use of this
| if (match == null) { | ||
| // Different exception for this case: CQL type supported but not from given Java type | ||
| // (f.ex, CQL Boolean from Java/JSON number) | ||
| throw new ToCQLCodecException( |
There was a problem hiding this comment.
This is an important change, the code to verify a document for inserting may need to change
| @@ -49,21 +61,35 @@ public class JSONCodecRegistry { | |||
| */ | |||
| public <JavaT, CqlT> JSONCodec<JavaT, CqlT> codecToCQL( | |||
| TableMetadata table, CqlIdentifier column, Object value) | |||
| throws UnknownColumnException, MissingJSONCodecException { | |||
| throws UnknownColumnException, MissingJSONCodecException, ToCQLCodecException { | |||
There was a problem hiding this comment.
Nit: the doc comments list all the errors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Changes linear-scan lookup into map-based lookup (one- or two-phase depending on direction). Also improves error messages for partial misses where we support CQL type but not particular coercion (like Boolean from Integer) to indicate it's Java value mismatch and not (fully) unsupported type.
Which issue(s) this PR fixes:
Fixes #1417
Checklist