Test Java Driver QueryBuilder private build, 4.19.0-preview1 #1615
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think this is failing due to missing there needs to be matching (and same for .pom files) |
…d-test' into driver-querybuilder-private-build-test
amorton
reviewed
Oct 30, 2024
| @@ -79,6 +79,14 @@ | |||
| </dependency> | |||
| </dependencies> | |||
| </dependencyManagement> | |||
| <!-- Add local repository for private java driver queryBuilder build to avoid using systemPath in dependency--> | |||
There was a problem hiding this comment.
nit: can we include a link to an issue in our repo or the java driver that explains what we are waiting on, and how we can checked if the work has been done. We need the issue to stay open until we revert this change.
amorton
approved these changes
Oct 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous PR for checking in the private java Driver 4.19.0-preview1 uses 'systemPath' to reference the jar. That is fine for Data API, however, it causes install problem to EGW which uses Data API as a jar. And it complains.
[ERROR] 'dependencies.dependency.systemPath' for com.datastax.oss:java-driver-query-builder:jar must specify an absolute path but is ${project.basedir}/lib/java-driver-query-builder-4.19.0-preview1.jar @So, we still need to check in the Driver jar into Data API repo, but can not use . So I changed in Data API pom to search Driver queryBuilder in local repository. In this way, we can have a walk around.
Also, tested in EGW, it can be successfully built with Data API v1.0.19-SNAPSHOT now.
Checklist