Support ANN sorting for tables #1620
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes the warnings associated commands to use the new ApiExcpetions, and `warnings` in the return status now returns a list of error object V2. To do that needed to improve the way CommandResult was built, so it always had a status map so the CommandProcessor could append a warning. To do that expanded the CommandResultBuilder added for the OperationAttempts, removed the many overloads used for CommandResult, and updated all creation of the CommandResult to use the builder. See also #1518 to continue this
…cResponses Missed adding errors to the CommandResult builder for per document responses in InsertOperationPage
- change CommandErrorV2 property to match bean style - change CreateKeyspaceIntegrationTest to get new response warning
and made both create and drop tests check the names of the commands in the message
- our schema cache was not invalidating when a table was changed, so we would always give out missing index errors rather than errors when index was there but did not support the operation - updated integration tests for the full error in the warning, and made them check the id for the warning - big fix, we were not turning on allow filtering when doing a comparison query for some data types on indexed columns
amorton
changed the title
Yuqi-Du
approved these changes
Oct 31, 2024
src/main/java/io/stargate/sgv2/jsonapi/api/model/command/clause/sort/SortExpression.java
Show resolved
Hide resolved
| return sortExpressions == null || sortExpressions.isEmpty(); | ||
| } | ||
|
|
||
| public List<SortExpression> tableVectorSorts() { |
There was a problem hiding this comment.
oh, tableVectorSorts means vector sort on a vector table column. and table column can't be $vector and $vectorize?
src/main/java/io/stargate/sgv2/jsonapi/service/operation/tables/TableANNOrderByCQlClause.java
Outdated
Show resolved
Hide resolved
src/main/java/io/stargate/sgv2/jsonapi/service/resolver/sort/TableSortClauseResolver.java
Show resolved
Hide resolved
| } else if (DataTypes.TINYINT.equals(type)) { | ||
| return JsonNodeFactory.instance.numberNode(Byte.valueOf("1")); | ||
| } else if (DataTypes.UUID.equals(type)) { | ||
| return JsonNodeFactory.instance.textNode("550e8400-e29b-41d4-a716-446655440000"); | ||
| } else if (DataTypes.VARINT.equals(type)) { | ||
| return JsonNodeFactory.instance.numberNode(BigDecimal.valueOf(1L)); | ||
| } else if (type.getClass().getName().startsWith(DefaultVectorType.VECTOR_CLASS_NAME)) { |
There was a problem hiding this comment.
This is not used, correct?
src/main/java/io/stargate/sgv2/jsonapi/service/operation/tables/TableANNOrderByCQlClause.java
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Currently handling sort as a CQL order by only works with vectors as float array
see also #1618 and #1628
Which issue(s) this PR fixes:
Fixes #1559
Checklist