Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes #1700 default limit for ANN find now 1k #1706

Merged
merged 2 commits into from
Nov 13, 2024

Conversation

amorton
Copy link
Contributor

@amorton amorton commented Nov 13, 2024

using the same configured AN find limit as collections, which is currently 1k

What this PR does:

Which issue(s) this PR fixes:
Fixes #1700

Checklist

  • Changes manually tested
  • Automated Tests added/updated
  • Documentation added/updated
  • CLA Signed: DataStax CLA

using the same configured AN find limit as collections, which
is currently 1k
@amorton amorton requested a review from a team as a code owner November 13, 2024 20:15
@Yuqi-Du
Copy link
Contributor

Yuqi-Du commented Nov 13, 2024

so if user specify a limit that is large than 1000 with ANN.
We will do that and return back the DB error. Correct?

@amorton
Copy link
Contributor Author

amorton commented Nov 13, 2024

so if user specify a limit that is large than 1000 with ANN. We will do that and return back the DB error. Correct?

good call, added this so we can get the fix in quickly #1707

@amorton amorton merged commit cb83b97 into main Nov 13, 2024
3 checks passed
@amorton amorton deleted the ajm/fix-1700-default-ann-limit branch November 13, 2024 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HTTP 500 when vector search w/ no limit
2 participants