Fix for countDocument regression #1711
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| }) | ||
| // Documents read until pageState available, max records read is deleteLimit + 1 TODO | ||
| // COMMENTS | ||
| .whilst(AsyncPagingIterable::hasMorePages) |
There was a problem hiding this comment.
Quick question: where is the "max count" checked? Looks like this would read through all entries and not stop at specific count? (I am probably missing something)
There was a problem hiding this comment.
this would be set in the CQL limit, the page size we tell the driver is how to chunk LIMIT number of rows.
There was a problem hiding this comment.
this looks like the code we came up with for in memory sorting for tables
There was a problem hiding this comment.
Ah. Yes, since that's within SimpleStatement being passed.
|
moving to draft due to last minute situation, the simple fix is #1715 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Count command fix
Which issue(s) this PR fixes:
Fixes #1708
Checklist