Support dot notation with $pop update operation #193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1347,6 +1413,8 @@ private void insertDoc(String docJson) { | |||
| .when() | |||
| .post(CollectionResource.BASE_PATH, keyspaceId.asInternal(), collectionName) | |||
| .then() | |||
| // Sanity check: let's look for non-empty inserted id | |||
There was a problem hiding this comment.
Needed because we always get 200 response; failure indicated differently so need to get inserted-id.
(not checking masked a few failures within invalid json being sent)
tatu-at-datastax
changed the title
maheshrajamani
approved these changes
Feb 25, 2023
|
|
||
| // Otherwise must be an array | ||
| if (value.isArray()) { // Already array? To modify unless empty | ||
| if (!value.isEmpty()) { |
There was a problem hiding this comment.
Interesting we have handled empty array. I just tested it with insert and find, it works!
There was a problem hiding this comment.
Ok good -- I thought it should but is good to confirm. Mongo array operators are pretty useful.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Changes
$popimplementation to support dotted paths too.Which issue(s) this PR fixes:
Fixes #184
Checklist