Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return deletedCount for deleteOne and deleteMany #195

Merged
merged 11 commits into from
Feb 27, 2023
Merged

Conversation

maheshrajamani
Copy link
Contributor

What this PR does:
Return deletedCount instead of deletedIds for deleteOne and deleteMany

Which issue(s) this PR fixes:
Fixes #194

Checklist

  • Changes manually tested
  • Automated Tests added/updated
  • Documentation added/updated
  • CLA Signed: DataStax CLA

@maheshrajamani maheshrajamani marked this pull request as ready for review February 27, 2023 14:59
@maheshrajamani maheshrajamani requested a review from a team as a code owner February 27, 2023 14:59
Copy link
Contributor

@tatu-at-datastax tatu-at-datastax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM -- minor suggestions for renaming, javadocs.

Changed the javadoc as per review comment
@maheshrajamani maheshrajamani merged commit 293140d into main Feb 27, 2023
@maheshrajamani maheshrajamani deleted the deletedCount branch February 27, 2023 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Return deletedCount for deleteOne and deleteMany
2 participants