Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #190: use order-sensitive equality comparison for Object-value $set update #220

Merged
merged 1 commit into from
Mar 6, 2023
Merged

Fix #190: use order-sensitive equality comparison for Object-value $set update #220

merged 1 commit into from
Mar 6, 2023

Conversation

tatu-at-datastax
Copy link
Contributor

What this PR does:

Adds test to ensure that $set will update Object values if field order is not same (Mongo expects order-sensitive comparison)

Which issue(s) this PR fixes:
Fixes #190

Checklist

  • Changes manually tested
  • Automated Tests added/updated
  • Documentation added/updated
  • CLA Signed: DataStax CLA

@tatu-at-datastax tatu-at-datastax requested a review from a team as a code owner March 2, 2023 21:57
@tatu-at-datastax tatu-at-datastax self-assigned this Mar 2, 2023
@tatu-at-datastax tatu-at-datastax merged commit 875c793 into main Mar 6, 2023
@tatu-at-datastax tatu-at-datastax deleted the tatu/190-set-object-prop-order branch March 6, 2023 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maheshrajamani maheshrajamani maheshrajamani approved these changes

Assignees

@tatu-at-datastax tatu-at-datastax

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Detect change in field order for $set update operator with Object value
2 participants
@tatu-at-datastax @maheshrajamani