New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added the FilterClause #23

Merged

maheshrajamani merged 10 commits into main from find

Jan 9, 2023

Contributor

maheshrajamani commented Jan 4, 2023

Creating smaller PR's for review


          Added the FilterClause

0b74a81

maheshrajamani requested a review from a team as a code owner

January 4, 2023 18:49

tatu-at-datastax reviewed

View reviewed changes

...main/java/io/stargate/sgv3/docsapi/api/model/command/clause/filter/ComparisonExpression.java Outdated Show resolved Hide resolved

tatu-at-datastax reviewed

View reviewed changes

src/main/java/io/stargate/sgv3/docsapi/api/model/command/clause/filter/FilterOperation.java Outdated Show resolved Hide resolved

tatu-at-datastax reviewed

View reviewed changes

src/main/java/io/stargate/sgv3/docsapi/api/model/command/clause/filter/JsonLiteral.java Outdated Show resolved Hide resolved

tatu-at-datastax reviewed

View reviewed changes

src/main/java/io/stargate/sgv3/docsapi/api/model/command/clause/filter/JsonLiteral.java Outdated Show resolved Hide resolved

tatu-at-datastax reviewed

View reviewed changes

...n/java/io/stargate/sgv3/docsapi/api/model/command/clause/filter/ValueComparisonOperator.java Show resolved Hide resolved

tatu-at-datastax reviewed

View reviewed changes

.../java/io/stargate/sgv3/docsapi/api/model/command/deserializers/FilterClauseDeserializer.java Outdated Show resolved Hide resolved

tatu-at-datastax reviewed

View reviewed changes

.../java/io/stargate/sgv3/docsapi/api/model/command/deserializers/FilterClauseDeserializer.java Show resolved Hide resolved

tatu-at-datastax approved these changes

View reviewed changes

ivansenic suggested changes

View reviewed changes

Contributor

ivansenic left a comment

Good stuff.. Left a lot of comments, but my main goal would be to add more tests here. We can not simply add code without any tests and there are bunch of branches here.. Let's do things in a correct way!

...main/java/io/stargate/sgv3/docsapi/api/model/command/clause/filter/ComparisonExpression.java Outdated Show resolved Hide resolved

src/main/java/io/stargate/sgv3/docsapi/api/model/command/clause/filter/JsonType.java Outdated Show resolved Hide resolved

src/main/java/io/stargate/sgv3/docsapi/api/model/command/clause/filter/JsonType.java Outdated Show resolved Hide resolved

src/main/java/io/stargate/sgv3/docsapi/api/model/command/clause/filter/JsonType.java Outdated Show resolved Hide resolved

...main/java/io/stargate/sgv3/docsapi/api/model/command/clause/filter/ComparisonExpression.java Outdated Show resolved Hide resolved

src/main/java/io/stargate/sgv3/docsapi/api/model/command/Filterable.java Outdated Show resolved Hide resolved

src/main/java/io/stargate/sgv3/docsapi/exception/ErrorCode.java Outdated Show resolved Hide resolved

src/test/java/io/stargate/sgv3/docsapi/api/configuration/ObjectMapperConfigurationTest.java Outdated Show resolved Hide resolved

src/test/java/io/stargate/sgv3/docsapi/api/configuration/ObjectMapperConfigurationTest.java Outdated Show resolved Hide resolved

src/test/java/io/stargate/sgv3/docsapi/api/configuration/ObjectMapperConfigurationTest.java Show resolved Hide resolved

maheshrajamani added 6 commits

January 5, 2023 14:20


          Added unit test cases

e5a648f

Changed the JsonLiteral as typed instead of using it on the methods.


          Added exception if case of object is in unsupported format

a788a9c


          Changes as per comments

704dd24


          Fix as per the review comment

f59f25b


          Added validation

7baab45


          Formatted the file

30ee572

maheshrajamani requested a review from ivansenic

January 6, 2023 15:29

maheshrajamani self-assigned this


          Added unit test case for match method

d7cf776

ivansenic reviewed

View reviewed changes

Contributor

ivansenic left a comment

Added few more comments.. Very good round of reviews.. Would like to see how can we finalize the generalization of the types 👍

...main/java/io/stargate/sgv3/docsapi/api/model/command/clause/filter/ComparisonExpression.java Outdated Show resolved Hide resolved

...main/java/io/stargate/sgv3/docsapi/api/model/command/clause/filter/ComparisonExpression.java Outdated Show resolved Hide resolved

...main/java/io/stargate/sgv3/docsapi/api/model/command/clause/filter/ComparisonExpression.java Outdated Show resolved Hide resolved

src/main/java/io/stargate/sgv3/docsapi/api/model/command/clause/filter/FilterOperation.java Outdated Show resolved Hide resolved

src/main/java/io/stargate/sgv3/docsapi/api/model/command/clause/filter/FilterOperation.java Outdated Show resolved Hide resolved

src/main/java/io/stargate/sgv3/docsapi/api/model/command/clause/filter/FilterOperator.java Outdated Show resolved Hide resolved

.../java/io/stargate/sgv3/docsapi/api/model/command/clause/filter/ComparisonExpressionTest.java Outdated Show resolved Hide resolved

src/test/java/io/stargate/sgv3/docsapi/api/configuration/ObjectMapperConfigurationTest.java Outdated Show resolved Hide resolved


          Resolved warnings and fixed based on reviews.

fa2ebb7

maheshrajamani requested a review from ivansenic

January 9, 2023 14:26

ivansenic reviewed

View reviewed changes

Contributor

ivansenic left a comment

Can you check if those suggestions below make sense?

src/main/java/io/stargate/sgv3/docsapi/api/model/command/clause/filter/FilterOperation.java Outdated Show resolved Hide resolved

src/main/java/io/stargate/sgv3/docsapi/api/model/command/clause/filter/FilterOperation.java Outdated Show resolved Hide resolved

.../java/io/stargate/sgv3/docsapi/api/model/command/clause/filter/ValueComparisonOperation.java Outdated Show resolved Hide resolved

...main/java/io/stargate/sgv3/docsapi/api/model/command/clause/filter/ComparisonExpression.java Outdated Show resolved Hide resolved


          Made the FilterOperation typed

6e6a9ec

maheshrajamani requested a review from ivansenic

January 9, 2023 17:33

ivansenic approved these changes

View reviewed changes

Contributor

ivansenic left a comment

🚀

maheshrajamani merged commit 2773469 into main

maheshrajamani deleted the find branch

January 9, 2023 20:24

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet