Implement $min and $max update operators #233
Conversation
tatu-at-datastax
changed the title
| * then recursively by value; and if first N fields the same, Object with more properties is sorted | ||
| * last. | ||
| */ | ||
| public class JsonNodeComparator implements Comparator<JsonNode> { |
There was a problem hiding this comment.
Cool. In memory sort made easy with this utility class.
There was a problem hiding this comment.
Yes, was about to suggest just that, was thinking about it.
There was a problem hiding this comment.
Cool. In memory sort made easy with this utility class.
There was a problem hiding this comment.
Cool. In memory sort made easy with this utility class.
| "updateOne": { | ||
| "filter" : {"_id" : "update_doc_min"}, | ||
| "update" : {"$min" : { | ||
| "min": 2, |
There was a problem hiding this comment.
Would be nice to have an integration test that uses $min and $max with types that aren't numbers. For example, $min: { foo: 'bar' }. That should work given the JsonNodeComparatorTest.java tests, but I think it's worth checking.
There was a problem hiding this comment.
Yeah. I did add unit tests for wider range given they are more compact, but yeah I could/should add at least one cross-type, and one non-number IT operation.
What this PR does:
Adds
$minand$maxupdate operatorsWhich issue(s) this PR fixes:
Fixes #223
Checklist