Fix #240: surround String-valued DocumentId in single quotes #241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tatu-at-datastax
changed the title
tatu-at-datastax
commented
Mar 9, 2023
| @@ -64,7 +64,7 @@ public static Map<QueryOuterClass.Value, QueryOuterClass.Value> getDoubleMapValu | |||
| public static List<QueryOuterClass.Value> getDocumentIdValue(DocumentId documentId) { | |||
| // Temporary implementation until we convert it to Tuple in DB | |||
| List<QueryOuterClass.Value> tupleValues = | |||
| List.of(Values.of(documentId.typeId()), Values.of(documentId.toString())); | |||
| List.of(Values.of(documentId.typeId()), Values.of(documentId.asDBKey())); | |||
There was a problem hiding this comment.
Necessary to avoid single-quotes from being added wrt DocumentId.toString() change: also semantically good to have separate method for use case.
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Enclose
String-valuedDocumentIdin single quotes, for use in Exception messages -- avoids confusion wrt id type, contents.Also adds a separate method to use for constructing DB primary keys, instead of
Document.toString().Which issue(s) this PR fixes:
Fixes #240
Checklist