cancel running ci workflows for pr branches #264
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivansenic
commented
Mar 15, 2023
| @@ -35,6 +40,9 @@ jobs: | |||
| name: Unit tests | |||
| runs-on: ubuntu-latest | |||
|
|
|||
| # max run time 5 minutes | |||
| timeout-minutes: 5 | |||
There was a problem hiding this comment.
added this as well.. sometimes jobs could hang and we want to avoid this..
jeffreyscarpenter
approved these changes
Mar 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Cancel existing workflows for PR branches on update. Meaning once you push a new commit to a PR branch, we will cancel the workflow that might still be running. This ensures even more saving of minutes and cancelling runs of unnecessary CI.
Which issue(s) this PR fixes:
Port of stargate/stargate#2493