Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add workflow to run NoSQLBench performance tests #279

Merged
merged 25 commits into from
Mar 22, 2023

Conversation

jeffreyscarpenter
Copy link
Contributor

add workflow to run NoSQLBench performance tests

Checklist

  • Changes manually tested
  • Automated Tests added/updated
  • Documentation added/updated
  • CLA Signed: DataStax CLA

Copy link
Contributor

@ivansenic ivansenic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know it's draft, bit still had a review, will help to speed up completion..

I still wander why I can not run this locally and keep getting:

   16996 WARN  [httpjsonapicrudbasic_default_read:063] ERRORS       error with cycle 39576 errmsg: java.util.concurrent.ExecutionException: java.io.IOException: too many concurrent streams

Seems that max file descriptors is not doing it..

EDIT: I know why it works in the actions, threads=auto sets threads to 10 x num_cores, which results in 20 on action runner. If I set threads=20 on my machine I don't get the errors.. This is however a huge limitation and we need to figure it out..

docker-compose/docker-compose-dev-mode.yml Outdated Show resolved Hide resolved
nosqlbench/http-jsonapi-crud-basic.yaml Outdated Show resolved Hide resolved
nosqlbench/http-jsonapi-crud-basic.yaml Outdated Show resolved Hide resolved
nosqlbench/http-jsonapi-crud-basic.yaml Outdated Show resolved Hide resolved
@@ -111,4 +114,3 @@ blocks:
X-Cassandra-Request-Id: "{request_id}"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • this won't work, you need delete one command?
  • uri includes the key

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test is still under construction, will work on it more in a separate PR

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK separate PR.

type: [ java, native ]

test: [ http-jsonapi-crud-basic, http-jsonapi-keyvalue ]
#test: [ http-jsonapi-crud-basic, http-jsonapi-keyvalue, http-jsonapi-search-basic, http-jsonapi-search-advanced ]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will be fixed, this is just a draft

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not done

.github/workflows/performance-testing.yaml Show resolved Hide resolved
.github/workflows/performance-testing.yaml Show resolved Hide resolved
.github/workflows/performance-testing.yaml Show resolved Hide resolved
.github/workflows/performance-testing.yaml Outdated Show resolved Hide resolved
@ivansenic
Copy link
Contributor

ivansenic commented Mar 22, 2023

@jeffreyscarpenter I'll add the space fix in a separate PR: #282

@@ -11,8 +11,8 @@ description: |
scenarios:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this file is missing a MD file

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There isn't one on the equivalent docs API test either. We'll come back and address separately.

@jeffreyscarpenter jeffreyscarpenter marked this pull request as ready for review March 22, 2023 14:26
@jeffreyscarpenter jeffreyscarpenter requested a review from a team as a code owner March 22, 2023 14:26
description: 'Number of documents to use for each test'
required: true
type: string
# TODO - set higher default?
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still not done?

type: [ java, native ]

test: [ http-jsonapi-crud-basic, http-jsonapi-keyvalue ]
#test: [ http-jsonapi-crud-basic, http-jsonapi-keyvalue, http-jsonapi-search-basic, http-jsonapi-search-advanced ]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not done

.github/workflows/performance-testing.yaml Show resolved Hide resolved
@@ -84,6 +86,7 @@ blocks:
X-Cassandra-Request-Id: "{request_id}"
X-Cassandra-Token: "<<auth_token:my_auth_token>>"
Content-Type: "application/json"
ok-body: ".*\"insertedIds\".*"
body: "{document_json}"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not done, ok separate PR

@@ -93,7 +96,7 @@ blocks:
X-Cassandra-Request-Id: "{request_id}"
X-Cassandra-Token: "<<auth_token:my_auth_token>>"
Content-Type: "application/json"
ok-status: "[2-4][0-9][0-9]"
ok-body: ".*\"data\".*"

update-document:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not done, ok separate PR

@@ -111,4 +114,3 @@ blocks:
X-Cassandra-Request-Id: "{request_id}"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK separate PR.

@jeffreyscarpenter jeffreyscarpenter merged commit 3ecbfd6 into main Mar 22, 2023
@jeffreyscarpenter jeffreyscarpenter deleted the jeff/perf-test branch March 22, 2023 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants