Bug fix for upsert if filter is based on non id filter #280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tatu-at-datastax
approved these changes
Mar 20, 2023
ivansenic
reviewed
Mar 21, 2023
| @@ -168,7 +170,7 @@ private Uni<UpdatedDocument> processUpdate( | |||
| v -> { | |||
| if (readDocument.txnId() != null) modifiedCount.incrementAndGet(); | |||
| return new UpdatedDocument( | |||
| readDocument.id(), | |||
| writableShreddedDocument.id(), | |||
There was a problem hiding this comment.
So how is this a fix and wouldn't this end up in the NPE in that else case? Something is off here..
There was a problem hiding this comment.
By default updated Document id (updated) is set as Uni.nullValue() when writableShreddedDocument is null. This handled in the below code as
updated
.onItem()
.ifNotNull()
There was a problem hiding this comment.
OK, I adapted this a bit in #281 We need to think about readbility of the code, and in general simplification where possible..
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Fix returning upsertedId if the filter is based on non id field.
Which issue(s) this PR fixes:
Fixes #273 and #275
Checklist