closes #350: errorCode and exceptionClass to be reported always with … #369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivansenic
commented
Apr 18, 2023
| @@ -59,6 +56,12 @@ public CommandResult get() { | |||
| } | |||
| } | |||
|
|
|||
| public CommandResult.Error getCommandResultError(String message) { | |||
| Map<String, Object> fields = | |||
| Map.of("errorCode", errorCode.name(), "exceptionClass", this.getClass().getSimpleName()); | |||
There was a problem hiding this comment.
the JsonApiException was not including the exceptionClass before so I added it, I guess this is also helpful information..
ivansenic
commented
Apr 18, 2023
| fields.put("errorCode", jae.getErrorCode().name()); | ||
| } | ||
| return new CommandResult.Error(message, fields); | ||
| return ThrowableToErrorMapper.getMapperWithMessageFunction().apply(throwable, message); |
There was a problem hiding this comment.
here I adapted this, the ExceptionUtil should not know how are CommandResult.Error instances created, cause we have a single place for that.. Adapted for custom message..
maheshrajamani
approved these changes
Apr 18, 2023
…JsonApiException command result
ivansenic
force-pushed
the
ise-350-error-chain
branch
from
fb302f2 to
661a067
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
As discussed in the #350 (comment) I pushed the implementation that fixes
errorCodemissing. We still need to agree on the handling of the cause and if we do want the error array to include the cause..Which issue(s) this PR fixes:
Fixes #350
Checklist