-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for 416 and 417 #419
Fix for 416 and 417 #419
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One minor comment but LGTM overall
.post(CollectionResource.BASE_PATH, namespaceName, collectionName) | ||
.then() | ||
.statusCode(200) | ||
.body("data.documents[0]._id", is(notNullValue())); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might be also good to check that the document's _id
is a string
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will do
Closing this for a new PR for new #421 |
What this PR does:
Fix for #416 and #417
Which issue(s) this PR fixes:
Fixes #416 and #417
Checklist