Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for 416 and 417 #419

Closed
wants to merge 9 commits into from
Closed

Fix for 416 and 417 #419

wants to merge 9 commits into from

Conversation

maheshrajamani
Copy link
Contributor

@maheshrajamani maheshrajamani commented May 9, 2023

What this PR does:
Fix for #416 and #417
Which issue(s) this PR fixes:
Fixes #416 and #417

Checklist

  • Changes manually tested
  • Automated Tests added/updated
  • Documentation added/updated
  • CLA Signed: DataStax CLA

@maheshrajamani maheshrajamani self-assigned this May 9, 2023
Copy link
Collaborator

@vkarpov15 vkarpov15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor comment but LGTM overall

.post(CollectionResource.BASE_PATH, namespaceName, collectionName)
.then()
.statusCode(200)
.body("data.documents[0]._id", is(notNullValue()));
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be also good to check that the document's _id is a string

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will do

@maheshrajamani
Copy link
Contributor Author

maheshrajamani commented May 9, 2023

Closing this for a new PR for new #421

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

findOneAndReplace upsert not generating _id
2 participants