Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create integration test for vector unmatched size(insert/find) #503

Merged
merged 2 commits into from
Aug 18, 2023

Conversation

Yuqi-Du
Copy link
Contributor

@Yuqi-Du Yuqi-Du commented Aug 11, 2023

What this PR does: Create integration tests for vector unmatched size(insert/find)

Which issue(s) this PR fixes:
Fixes #<497>

Checklist

  • Changes manually tested
  • Automated Tests added/updated
  • Documentation added/updated
  • CLA Signed: DataStax CLA

@Yuqi-Du Yuqi-Du requested a review from a team as a code owner August 11, 2023 20:46
.then()
.statusCode(200)
.body("errors", is(notNullValue()))
.body("errors[0].message", endsWith("Expected vector of 5 size, but received 3"));
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe better to say "expected vector of length 5", "5 size" reads a bit awkwardly.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Fixed that.

Copy link
Collaborator

@vkarpov15 vkarpov15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor comment, LGTM otherwise

@Yuqi-Du Yuqi-Du merged commit 3ebc23c into main Aug 18, 2023
@Yuqi-Du Yuqi-Du deleted the IT_vector_unmatched_size branch August 18, 2023 00:32
@Yuqi-Du
Copy link
Contributor Author

Yuqi-Du commented Aug 18, 2023

Merged, two IT failed, that is because they rely on a new release for Main Repo.
Main Repo change, merged not released

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants