Fix #521: allow hyphen in names, prevent empty String #522
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@maheshrajamani Could you also review this when you get a chance? |
maheshrajamani
approved these changes
Sep 8, 2023
There was a problem hiding this comment.
@tatu-at-datastax Can you add insert and find (filter) IT for this case?
Yes that sounds reasonable. |
| @@ -67,22 +67,47 @@ public void insertDocument() { | |||
| .body("status.insertedIds[0]", is("doc3")) | |||
| .body("data", is(nullValue())) | |||
| .body("errors", is(nullValue())); | |||
| given() | |||
There was a problem hiding this comment.
Existing not change, just inlined JSON payloads for bit more compact code.
|
@maheshrajamani Added insert and find test cases, will merge once CI passes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Improves property name validation wrt #521 so that:
-) in names and name segmentsWhich issue(s) this PR fixes:
Fixes #521
Checklist