Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moved JAVA_OPTS_APPEND out of Dockerfile #665

Merged
merged 4 commits into from
Nov 22, 2023
Merged

Conversation

kathirsvn
Copy link
Contributor

What this PR does:
Moved JAVA_OPTS_APPEND out of Dockerfile so we can pass jvm args as required from docker compose file, k8s yaml, etc.

Which issue(s) this PR fixes:
Related to #662

Checklist

  • Changes manually tested
  • Automated Tests added/updated
  • Documentation added/updated
  • CLA Signed: DataStax CLA

@kathirsvn kathirsvn requested a review from a team as a code owner November 21, 2023 07:47
@kathirsvn kathirsvn merged commit a4d5254 into main Nov 22, 2023
3 checks passed
@kathirsvn kathirsvn deleted the java_opts_append_fix branch November 22, 2023 03:25
@jeffreyscarpenter
Copy link
Contributor

Docker compose files are now broken. Log from JSON API container:

2023-11-22 13:03:07 INFO exec -a "java" java -XX:InitialRAMPercentage=50.0 -XX:MaxRAMPercentage=75.0 -XX:+UseG1GC -XX:MinHeapFreeRatio=10 -XX:MaxHeapFreeRatio=20 -XX:GCTimeRatio=4 -XX:AdaptiveSizePolicyWeight=90 -XX:+ExitOnOutOfMemoryError "-Dquarkus.http.host=0.0.0.0 -Djava.util.logging.manager=org.jboss.logmanager.LogManager" -cp "." -jar /deployments/quarkus-run.jar 
2023-11-22 13:03:07 INFO running in /deployments
2023-11-22 13:03:07 Error: Could not find or load main class "-Dquarkus.http.host=0.0.0.0
2023-11-22 13:03:07 Caused by: java.lang.ClassNotFoundException: "-Dquarkus.http.host=0.0.0.0

@kathirsvn kathirsvn mentioned this pull request Nov 23, 2023
4 tasks
@kathirsvn
Copy link
Contributor Author

My bad, fixed it in this PR #678 Can I get a review/approval for that please?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants