Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes with cassandra not operator #721

Merged
merged 18 commits into from
Dec 13, 2023
Merged

Conversation

Yuqi-Du
Copy link
Contributor

@Yuqi-Du Yuqi-Du commented Dec 11, 2023

What this PR does:

$exists support false
$ne support for number, text, null, array, sub_doc, date, _id
$nin support for non_id and id

Which issue(s) this PR fixes:
Fixes #709, #711, jira sai tickets

Checklist

  • Changes manually tested
  • Automated Tests added/updated
  • Documentation added/updated
  • CLA Signed: DataStax CLA

(need v2.1 release)
IT will fail, since IT relies on cassandra backend with no support for not operator
(many corners cases)
…a_not_operator

# Conflicts:
#	src/main/java/io/stargate/sgv2/jsonapi/api/model/command/clause/filter/ValueComparisonOperator.java
#	src/main/java/io/stargate/sgv2/jsonapi/service/operation/model/impl/DBFilterBase.java
@Yuqi-Du Yuqi-Du requested a review from a team as a code owner December 11, 2023 16:32
Copy link
Contributor

@maheshrajamani maheshrajamani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Yuqi-Du Yuqi-Du merged commit 8d2ca6e into main Dec 13, 2023
3 checks passed
@Yuqi-Du Yuqi-Du deleted the changes_with_cassandra_not_operator branch December 13, 2023 20:28
Copy link
Collaborator

@vkarpov15 vkarpov15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Only thing I'd like to see is a test for $ne with an array, I didn't see that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

$nin support
5 participants