-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
relates to #178: adapt countDocuments per spec, improve tests #202
Conversation
@vkarpov15 Can you confirm if countDocuments response element has to be count or counted_documents? Remember seeing counted_documents response name in some documentation. |
@maheshrajamani either |
I was trying to figure out Mongo equivalent, but https://www.geeksforgeeks.org/mongodb-countdocuments-method/ but regardless seems to just return raw numeric count, not a BSON Object. @vkarpov15 You probably know this are best, WDYT? |
@tatu-at-datastax @maheshrajamani I am not sure if I can merge this now? Will you provide your reviews? |
@tatu-at-datastax Mongoose expects |
OK I am merging this when I fix remaining tasks. |
Sorry, I am fine with the change, just wanted to verify I understood if it's different from Mongo handling; and if so if it is intentional and not accidental. Since it's intentional that's fine. And I think the benefit for us has more to do with unified response (Page object). Mongo probably has/had backwards compatibility concern to worry about, probably chose return type before more unified handling. |
098c16e
to
29d8098
Compare
Will merge this, and add the error test case when updating SG to |
What this PR does:
Adaptation to spec for the
countDocuments
, including test improvements.count
as per spec, fromcounted_documents
(@kathirsvn fyi)@Test
annotationWhich issue(s) this PR fixes:
Relates to #178.