Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

relates to #178: namespace and collection commands per spec #268

Merged
merged 2 commits into from
Mar 16, 2023
Merged

relates to #178: namespace and collection commands per spec #268

merged 2 commits into from
Mar 16, 2023

Conversation

ivansenic
Copy link
Contributor

What this PR does:

Makes createNamespace, createCollection & deleteCollection per spec:

  • match name patterns and size limitations
  • add validation tests
  • add missing resolver tests

@ivansenic ivansenic requested a review from a team as a code owner March 16, 2023 09:54
@sync-by-unito sync-by-unito bot mentioned this pull request Mar 16, 2023
Closed
maheshrajamani
maheshrajamani approved these changes Mar 16, 2023
View reviewed changes
Copy link
Contributor

@maheshrajamani maheshrajamani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ivansenic ivansenic merged commit b317738 into main Mar 16, 2023
@ivansenic ivansenic deleted the ise-178-create-collection-remove-options branch March 16, 2023 15:53
vkarpov15
vkarpov15 reviewed Mar 17, 2023
View reviewed changes
Copy link
Collaborator

@vkarpov15 vkarpov15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ivansenic ivansenic mentioned this pull request Mar 30, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vkarpov15 vkarpov15 vkarpov15 left review comments

@maheshrajamani maheshrajamani maheshrajamani approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ivansenic @vkarpov15 @maheshrajamani