-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add workflow to run NoSQLBench performance tests #279
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know it's draft, bit still had a review, will help to speed up completion..
I still wander why I can not run this locally and keep getting:
16996 WARN [httpjsonapicrudbasic_default_read:063] ERRORS error with cycle 39576 errmsg: java.util.concurrent.ExecutionException: java.io.IOException: too many concurrent streams
Seems that max file descriptors is not doing it..
EDIT: I know why it works in the actions, threads=auto
sets threads to 10 x num_cores
, which results in 20
on action runner. If I set threads=20
on my machine I don't get the errors.. This is however a huge limitation and we need to figure it out..
@@ -111,4 +114,3 @@ blocks: | |||
X-Cassandra-Request-Id: "{request_id}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- this won't work, you need delete one command?
- uri includes the key
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This test is still under construction, will work on it more in a separate PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK separate PR.
type: [ java, native ] | ||
|
||
test: [ http-jsonapi-crud-basic, http-jsonapi-keyvalue ] | ||
#test: [ http-jsonapi-crud-basic, http-jsonapi-keyvalue, http-jsonapi-search-basic, http-jsonapi-search-advanced ] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
will be fixed, this is just a draft
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not done
@jeffreyscarpenter I'll add the space fix in a separate PR: #282 |
@@ -11,8 +11,8 @@ description: | | |||
scenarios: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this file is missing a MD file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There isn't one on the equivalent docs API test either. We'll come back and address separately.
description: 'Number of documents to use for each test' | ||
required: true | ||
type: string | ||
# TODO - set higher default? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still not done?
type: [ java, native ] | ||
|
||
test: [ http-jsonapi-crud-basic, http-jsonapi-keyvalue ] | ||
#test: [ http-jsonapi-crud-basic, http-jsonapi-keyvalue, http-jsonapi-search-basic, http-jsonapi-search-advanced ] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not done
@@ -84,6 +86,7 @@ blocks: | |||
X-Cassandra-Request-Id: "{request_id}" | |||
X-Cassandra-Token: "<<auth_token:my_auth_token>>" | |||
Content-Type: "application/json" | |||
ok-body: ".*\"insertedIds\".*" | |||
body: "{document_json}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not done, ok separate PR
@@ -93,7 +96,7 @@ blocks: | |||
X-Cassandra-Request-Id: "{request_id}" | |||
X-Cassandra-Token: "<<auth_token:my_auth_token>>" | |||
Content-Type: "application/json" | |||
ok-status: "[2-4][0-9][0-9]" | |||
ok-body: ".*\"data\".*" | |||
|
|||
update-document: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not done, ok separate PR
@@ -111,4 +114,3 @@ blocks: | |||
X-Cassandra-Request-Id: "{request_id}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK separate PR.
add workflow to run NoSQLBench performance tests
Checklist