separate nosqlbench execution in spaces to have more connections #282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
ivansenic
force-pushed
the
ise-nosql-spaces
branch
from
c9177d6 to
fc923fc
Compare
| @@ -58,6 +58,7 @@ Note that error handling is set to `errors=timer,warn`, which means that in case | |||
| ## Workload Parameters | |||
|
|
|||
| - `docscount` - the number of documents to process in each step of a scenario (default: `10_000_000`) | |||
| - `connections` - number of HTTP2 connections to be shared between the threads (default: `20`) | |||
There was a problem hiding this comment.
how does this relate to the threads? If I set threads=10 and connections=20 what happens? Should we provide guidance on whether these need to be tuned together?
Would it make sense to reframe this as a number of connections per thread, or perhaps I misunderstand how this works?
There was a problem hiding this comment.
threads=10 and connections=20- each thread own connection..- connections per thread would be great, but I don't know how to do that? do you know?
There was a problem hiding this comment.
Let's not worry about this now.
| @@ -91,6 +95,7 @@ blocks: | |||
| ops: | |||
| # aka insertOne | |||
| write-document: | |||
| space: "{space}" | |||
There was a problem hiding this comment.
Do we have to add this to every instruction because of a shortcoming in NoSQLBench?
There was a problem hiding this comment.
Yes, see: nosqlbench/nosqlbench#1182
jeffreyscarpenter
approved these changes
Mar 23, 2023
|
@jeffreyscarpenter merging this, thanks for all the contributions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Enable nosqlbench test to send requests over multiple HTTP2 connections, thus allowing high number of threads and custom configurability. We can now specify how many threads to run and how many connections to use, for example:
threads=30 connections=30- each request has it's own connectionsthreads=30 connections=3- group of 10 request would use same connection (sequence1, 4, 7, etc)threads=30 connections=1- all requests executed over a single connection (multiplex and limited by the max http2 concurrent streams)