Fix _id field returned for findOneAndReplace and findOneAndUpdate with upsert option #421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivansenic
reviewed
May 9, 2023
| shredder().shred(documentUpdaterResponse.document(), readDocument.txnId()); | ||
|
|
||
| // Have to do this because shredder adds _id field to the document if it doesn't exist | ||
| JsonNode updatedDocument = writableShreddedDocument.docJsonNode(); |
There was a problem hiding this comment.
Maybe we should improve the shredded document impl and avoid this side effect call?
There was a problem hiding this comment.
That sounds like a good improvement idea; something that handles insertion and reordering of _id before Shredder gets to deal with it.
I'll create a follow-up issue.
maheshrajamani
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Fix for Issue #416 and #417, replacement PR for #419
Which issue(s) this PR fixes:
Fixes #416 and #417
Checklist