Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: addressables support #47

Merged
merged 74 commits into from
Jul 7, 2023
Merged

feat!: addressables support #47

merged 74 commits into from
Jul 7, 2023

Conversation

starikcetin
Copy link
Owner

@starikcetin starikcetin commented Jun 10, 2023

Closes #6
Closes #27
Closes #14


Todo:

  • Addressables support
  • Unit tests
  • "Make addressable" inline utility along with regular scene inline utilities
  • Color addressable scenes differently (add a settings entry for it also)
  • Changelog
  • Documentation
  • Repo assets (include that we also provide address)

@starikcetin starikcetin self-assigned this Jun 10, 2023
BREAKING CHANGE: All exceptions are moved to under the new `Eflatun.SceneReference.Exceptions` namespace. Add using directives to your code in order to upgrade.
BREAKING CHANGE: The validation properties have been removed. Instead, the new `State` property has been introduced. Please convert your usages as follows:
1. `IsSafeToUse` -> `State == Regular` or `State == Addressable`
2. `!IsSafeToUse` -> `State == Unsafe`
@starikcetin starikcetin changed the title feat: addressables support feat!: addressables support Jun 10, 2023
@starikcetin starikcetin force-pushed the addressables-support branch from 08f5f61 to 83e7192 Compare July 2, 2023 14:57
@starikcetin starikcetin marked this pull request as ready for review July 5, 2023 01:28
@starikcetin starikcetin merged commit 8d2cbef into main Jul 7, 2023
@starikcetin starikcetin deleted the addressables-support branch July 7, 2023 14:33
This was referenced Jul 7, 2023
@starikcetin
Copy link
Owner Author

Included in 3.0.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Visually improve inline utility Addressable Scene Support
1 participant