Modify to_bits implementations
#61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xLucqs
approved these changes
Apr 22, 2024
maciejka
reviewed
Apr 22, 2024
maciejka
approved these changes
Apr 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request type
Please add the labels corresponding to the type of changes your PR introduces:
What is the new behavior?
to_bits_leandto_bits_beimplementations are modified to take into account existing Lambdaworks implementation:https://github.com/lambdaclass/lambdaworks/blob/1a6d14ee7def60d0692d2b8fd323ca0d494920fd/math/src/field/fields/fft_friendly/stark_252_prime_field.rs#L50-L67
bitvecdependency is removedDoes this introduce a breaking change?
No
Other information