Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cut in initial Xcode support for v6 #2

Merged
merged 1 commit into from
Nov 3, 2021
Merged

Conversation

starkos
Copy link
Owner

@starkos starkos commented Oct 19, 2021

What does this PR do?

Adds initial Xcode support to Premake6, bringing it up to level with the current Visual Studio exporter: it can generate Xcode projects for itself, which build and work. Only features required to meet that target have been implemented; much of the exported projects are still hardcoded.

How does this PR change Premake's behavior?

Adds a new xcode action. Fixes lots of bugs discovered along the way.

Anything else we should know?

  • This includes fixes for a lot of issues I discovered along the way, not all of which were directly related to getting Xcode working. Let me know if you think it is better to just merge them as-is (faster) or break them out into separate commits (more "correct").
  • I still need to fill in documentation for the new APIs which were added. I'm debating if I want to do that as part of this PR, or if it would be better to follow up with another, documentation-oriented commit where I just fill in as much as I can.

Did you check all the boxes?

  • Focus on a single fix or feature; remove any unrelated formatting or code changes (not really, see above)
  • Add unit tests showing fix or feature works; all tests pass
  • Mention any related issues (put closes #XXXX in comment to auto-close issue when PR is merged)
  • Follow our coding conventions
  • Minimize the number of commits
  • Align documentation to your changes (not really, see above)

You can now support Premake on our OpenCollective. Your contributions help us spend more time responding to requests like these!

@starkos
Copy link
Owner Author

starkos commented Oct 20, 2021

FYI, I'm cutting a new branch to get started on filling in the documentation, so I'd prefer to handle that in a follow-up PR if there are no major objections.

@starkos starkos merged commit 923e363 into 6.x Nov 3, 2021
@starkos starkos deleted the feature/xcode-initial branch November 3, 2021 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant